oma refactor: refactor to `spdlog-rs` instead of `tracing`

Refactor tracing to spdlog-rs for logging.

This closes #486 .

cc @SpriteOvO

Sep 05 '25 07:09 NotEvenANeko

Initially it looks good, but what I'm wondering is whether we should just replace the tracing family directly with spdlog instead of optional?

Sep 05 '25 07:09 eatradish

Yeah we should replace tracing with spdlog, current codes is just convenient for debugging. I'll delete the tracing codes after spdlog parts are good to go.

Sep 05 '25 07:09 NotEvenANeko

FYI, SpriteOvO/spdlog-rs#93 is merged.

Sep 17 '25 04:09 SpriteOvO

I'll work on this PR tomorrow.

Sep 17 '25 04:09 NotEvenANeko

spdlog-rs is set to main-dev branch now.

Sep 19 '25 07:09 NotEvenANeko

FYI, we have just released spdlog-rs v0.5.0. You could target the dependency spdlog-rs in this PR to the crates.io registry now.

Oct 02 '25 20:10 SpriteOvO

Updated to v0.5.0

Oct 02 '25 21:10 NotEvenANeko

Doc tests should be fixed now

Oct 05 '25 17:10 NotEvenANeko

Ok I think clippy check is passed now...

Oct 13 '25 10:10 NotEvenANeko

Basically LGTM, @eatradish is there anything you are still concerned about?

LGTM, I'll test the functionality tomorrow

Oct 15 '25 10:10 eatradish

80col limit feature is broken

Oct 16 '25 08:10 eatradish

I'm so sorry for AFK for 3 weeks, I'm busy at study recently so I don't have much time for this, really sorry for this :(

I'm continue this PR now.

After reviewing the code I think that if we can migrate console.rs/src/writer.rs to spdlog-rs? Since the Writer directly use console crate to print the log.

We can migrate all the Writer functions and behavior to OmaFormatter and remove Writer.

Will it be a good idea? 🤔

Nov 07 '25 20:11 NotEvenANeko

@NotEvenANeko

We can migrate all the Writer functions and behavior to OmaFormatter and remove Writer.

Will it be a good idea? 🤔

I think putting the behavior "writing to console" into a formatter is not an ideal design. Why don't we just replace the field term: Term in Writer with buf: String, then return it from the formatter?

Nov 08 '25 06:11 SpriteOvO

Not the print to console behavior, I mean that we can move the formatting part into OmaFormatter, and the printing part is obviously moved to StdStreamSink. However we may need information against terminal, I think we can make an OmaStdoutFormatter to handle terminal-related formatting instead of leaving these parts mixed together in Writer.

Nov 13 '25 23:11 NotEvenANeko

Not the print to console behavior, I mean that we can move the formatting part into OmaFormatter, and the printing part is obviously moved to StdStreamSink. However we may need information against terminal, I think we can make an OmaStdoutFormatter to handle terminal-related formatting instead of leaving these parts mixed together in Writer.

I think it's acceptable.

Nov 16 '25 15:11 SpriteOvO