rqt_multiplot_plugin icon indicating copy to clipboard operation
rqt_multiplot_plugin copied to clipboard

Is there any plan to port this project to ROS2?

Open xhuan28 opened this issue 5 years ago • 21 comments

Is there any plan to port this project to ROS2?

xhuan28 avatar Sep 12 '19 06:09 xhuan28

@kralf Maybe some guides where to start for those who dare to try? :)

yossioo avatar Jan 01 '20 12:01 yossioo

I would also be very interested for a ROS2 Foxy version. I'll like to try but a guide to which files are specific to ROS and which are not would be nice. Also, one big issue will definitely be the issue of QoS compatibility between publishers and subscribers

AmaurX avatar Feb 03 '21 14:02 AmaurX

Any update on this? I am also interested on running multiplot on ROS2. Did anyone found another solution or a guideline to adapt this solution?

GuihVicentini avatar Apr 10 '22 14:04 GuihVicentini

Hello everyone,

we do not have plans at the moment to port this package to ROS2. If anyone wants to contribute, I am happy to create a ros2 branch!

remod avatar Apr 11 '22 07:04 remod

Hi @remod I kind of have interest on this, but I am clueless on what are exactly the ROS1 dependencies on this project. Could you give me a starting point?

GuihVicentini avatar Apr 18 '22 13:04 GuihVicentini

Hi @GuihVicentini

I am unsure whether I understood the question correctly - does the migration guide to ROS2 help?

remod avatar Apr 19 '22 06:04 remod

Hi @remod,

First overall, @kralf, @remod and others, kudos for the fantastic project!

It would be super to have this plugin in ROS2. Were there some steps taken in this direction? If not, I can take care of it. I will be doing it in my free time, so it probably will take a while to do this porting, but I hope not longer than to end of this year :P

abrzozowski avatar Oct 30 '22 13:10 abrzozowski

Hi @abrzozowski

That would be great, thank you! We're still using ROS1 and therefore cannot assist with the implementation, but we can help with the review! How would you like to proceed? Create a ros2 branch?

remod avatar Oct 31 '22 08:10 remod

Hi @remod,

Great! I will create a fork of this repo, and I will be porting on this fork. When everything works, I will create a PR to this main repo (https://github.com/ANYbotics/rqt_multiplot_plugin). Then we'll do the review. Is it a good plan?

I think that creating a ros2 branch in the main repo is an excellent idea because it can show others that there is someone who works on porting.

abrzozowski avatar Oct 31 '22 18:10 abrzozowski

Yes that sounds great!

One input from my side: ROS2 brings along some code formatting tools. To ensure that potential bugfixes are compatible with both versions of rqt_multiplot_plugin, ROS1 and ROS2, I suggest that we do not reformat code on the ROS2 branch - is this fine for you?

remod avatar Nov 01 '22 07:11 remod

Ok, I thought about it. I will be changing as minimally as possible. This approach should help with future merging ros1-releases into ros2 as well

abrzozowski avatar Nov 01 '22 09:11 abrzozowski

I've taken a look at what is a work scope. There is one more package to port except this, a https://github.com/ANYbotics/variant. The rqt_multiplot_plugin is dependent on the variant

abrzozowski avatar Nov 02 '22 19:11 abrzozowski

Yes exactly. In case you are not aware, the variant package does some ROS message definition parsing. Porting it to ROS2 might involve a bit more work than usually when porting a node.

remod avatar Nov 03 '22 07:11 remod

Is there any ongoing activity on this topic?

nlamprian avatar Aug 14 '23 11:08 nlamprian

Hi @nlamprian !

I personally am not aware of any activity.

remod avatar Aug 14 '23 12:08 remod

OK, I'll see if I can get involved. This tool deserves to stay alive!

nlamprian avatar Aug 14 '23 12:08 nlamprian

Nice to hear, thank you! :)

remod avatar Aug 14 '23 12:08 remod

I'm back with rqt_multiplot_bridge. I chose the less painful option of using a ROS bridge. This will have to do for now.

I also tried to make it work with docker compose, but the window would not open. If you have any idea how to configure it, feel free to open a PR.

nlamprian avatar Aug 14 '23 18:08 nlamprian

Hi, guys. Unfortunately, from my side, the porting didn't really move forward. The variant also still needs to be ported. But I still hold onto the hope that I'll get it done this year.

abrzozowski avatar Aug 15 '23 07:08 abrzozowski

I really liked using rqt_multiplot on ros1. Any news on porting to ros2?

amburkoff avatar Jan 09 '24 13:01 amburkoff

Unfortunately, I haven't found the time so far to do it. So, officially, I'm saying that I'm not currently dealing with it :(

abrzozowski avatar Jan 14 '24 18:01 abrzozowski