grid_map icon indicating copy to clipboard operation
grid_map copied to clipboard
verified publisher icon ANYbotics

[ROS 2][grid_map_core] Code enhancements from master b7293f5

Open kjalloul-anybotics opened this issue 1 year ago • 2 comments

Cherry-picked commit b7293f5 (No PR)

Includes fixing typos, math.h to cmath, push_back to emplace_back, and other code improvements.

kjalloul-anybotics avatar Nov 29 '24 11:11 kjalloul-anybotics

Can you post the clang warnings this solves? Note that the change of the type to a function and the removal of const are ABI breaking, so this can only be merged to rolling

Ryanf55 avatar Nov 29 '24 16:11 Ryanf55

One more thing - if this solves all of the clang warnings, it would be fantastic to add a CI job that enforces no new clang warnings. That would be a nice follow up to this.

Ryanf55 avatar Nov 29 '24 16:11 Ryanf55