grid_map icon indicating copy to clipboard operation
grid_map copied to clipboard

Port Add height of cluster with the most points method #323 to master

Open kosuke55 opened this issue 3 years ago • 10 comments

I ported #323 to master. (ros2 -> ros1) height_thresh is a parameter to reduce the influence of point clouds that exist in high locations such as ceilings.

0: Smallest value among the average values ​​of each cluster (current method) Screenshot from 2021-11-28 13-56-53

1: Largest value among the average values ​​of each cluster (current method which is implemeted only for ros1) Screenshot from 2021-11-28 13-57-09

2: Mean value of the cluster with the most (new method) Screenshot from 2021-11-28 13-57-30

kosuke55 avatar Nov 28 '21 05:11 kosuke55

Hey, some changes have been merged, or will be merged, can you update the MR?

maximilianwulf avatar Nov 30 '21 16:11 maximilianwulf

@maximilianwulf OK, please wait.

kosuke55 avatar Dec 01 '21 08:12 kosuke55

Thank you, will import the MR.

maximilianwulf avatar Dec 03 '21 13:12 maximilianwulf

One unit test was failing due to the API change, I fixed it internally. Could you provide a second MR with a unit test of this code change?

maximilianwulf avatar Dec 03 '21 17:12 maximilianwulf

@maximilianwulf I fixed CalculateElevation unit test. https://github.com/ANYbotics/grid_map/pull/329/commits/0a234582a0318378aa3b4de522c89b6954fd85cb

kosuke55 avatar Dec 04 '21 11:12 kosuke55

@maximilianwulf I fixed according to your comment, so please check it.

kosuke55 avatar Jan 09 '22 11:01 kosuke55

ping @maximilianwulf

kosuke55 avatar Feb 15 '22 06:02 kosuke55

ping @maximilianwulf

kosuke55 avatar Jul 17 '22 05:07 kosuke55

friendly ping @maximilianwulf

kosuke55 avatar Oct 04 '22 08:10 kosuke55

kindly ping @maximilianwulf

kosuke55 avatar Oct 18 '22 06:10 kosuke55