grid_map icon indicating copy to clipboard operation
grid_map copied to clipboard

[ros2] Build fails when using rosbag2 foxy-future version

Open SivertHavso opened this issue 3 years ago • 0 comments

The foxy-devel branch of grid_map builds fine against the foxy rosbag2 binary release, however trying to build it against the foxy-future version of rosbag2 fails because of rosbag2_cpp::StorageOptions being replaced by rosbag2_storage::StorageOptions.

grid_map_ros/src/GridMapRosConverter.cpp: In static member function ‘static bool grid_map::GridMapRosConverter::saveToBag(const grid_map::GridMap&, const string&, const string&)’: grid_map_ros/src/GridMapRosConverter.cpp:670:16: error: ‘StorageOptions’ is not a member of ‘rosbag2_cpp’ 670 | rosbag2_cpp::StorageOptions storage_options;

Building grid_map_ros from the ros2 branch (which already uses the updated StorageOptions struct) doesn't work either because that version of GridMapRosConverter.cpp makes use of rosidl_generator_traits::to_yaml which isn't available in ROS2 Foxy.

Might not be worth adding support for rosbag2 foxy-future here, but I thought I'd at least point out the issue.

For some context on the rosbag2 foxy future version see: https://discourse.ros.org/t/fast-forward-merging-rosbag2-master-api-to-foxy/18927/14. The short version is that it has about a years worth of major performance improvements over the original foxy version, but the changes are API/ABI breaking.

SivertHavso avatar Aug 24 '21 01:08 SivertHavso