elevation_mapping icon indicating copy to clipboard operation
elevation_mapping copied to clipboard

Visibility Cleanup (Possible) Deadlock

Open itaouil opened this issue 3 years ago • 3 comments

Hi :),

I am testing the elevation mapping package (thanks a lot for making it available), and I have noticed that whenever the visibility_cleanup or continuous_cleanup are set to true the program deadlocks on the call to the clear() routine in the ElevationMap.cpp class.

I have not carried out a thorough debugging yet, but given the consistency at which the lock happens, I would assume that is the case.

I also checked issue #129 where the same problem first appeared, and for which the update made should have fixed the issue, but it seems that was not the case when the clear() function is called within the pointCloudCallback and not as a service.

Were you aware of this?

P.S: I am using the master branch.

Best, Ilyass

itaouil avatar May 28 '21 13:05 itaouil

Hi @itaouil, thank you, yes we are aware of this. But due to resource scarcity, this was not yet addressed. In case you want to submit a fix feel free to do so.

maximilianwulf avatar May 31 '21 17:05 maximilianwulf

Hi @maximilianwulf,

I added it to my todo list :).

I might get to it in the next few weeks or so and if I manage to fix it, I will certainly file in a pull-request.

itaouil avatar Jun 01 '21 08:06 itaouil

That is very welcome, thank you.

maximilianwulf avatar Jun 01 '21 08:06 maximilianwulf