nginx make hostname update as optional

make hostname update as optional

Open TinOo512 opened this issue 9 years ago • 7 comments

We moved the work of @welcoMattic (https://github.com/ANXS/nginx/pull/48) in our organisation.

So this PR is now split and clean.

Nov 03 '15 11:11 TinOo512

Seems fine to me.... @soupdiver seems like you've been following this thread? care to merge?

Nov 03 '15 16:11 farridav

I like this concept, but it changes the default behavior of the role. @soupdiver thoughts ?

Nov 03 '15 21:11 otakup0pe

Like geoip I can set hostname_update: true by default. Let me know :)

Nov 04 '15 14:11 TinOo512

Agree with @otakup0pe that we should keep the behaviour backwards compatible. So changing the default would be nice :)

Nov 05 '15 08:11 soupdiver

@soupdiver done :)

Nov 05 '15 09:11 TinOo512

LGTM

Dec 29 '15 22:12 soupdiver

If we can get the conflict dealt with I'll totally merge this.

Also if y'all are interested in helping formally maintain this role, let me know.

Apr 21 '17 06:04 otakup0pe