ANTsPy icon indicating copy to clipboard operation
ANTsPy copied to clipboard

ants/segmentation/label_geometry_measures.py will need updating when ANTs version is bumped

Open cookpa opened this issue 1 year ago • 7 comments

Physical volume of labels will be included in the output after merging

https://github.com/ANTsX/ANTs/pull/1737

Currently, label_geometry_measures.py creates this on the fly.

cookpa avatar May 02 '24 20:05 cookpa

agree - just want the "new" version to "look like" the old one ... extra / new entries are ok but if it's possible to maintain the same naming - that would be very helpful.

stnava avatar May 02 '24 20:05 stnava

Understood

cookpa avatar May 02 '24 21:05 cookpa

OK used the column name "VolumeInMillimeters", Flatlanders will have to deal.

Now the only change required will be to not duplicate the "VolumeInMillimeters" column in the function, since it will already be there.

cookpa avatar May 02 '24 23:05 cookpa

yeah, i've seen that and i'm guessing it was my fault. would this be a problem @stnava if we fixed it?

ntustison avatar May 02 '24 23:05 ntustison

here is the check if it will be a problem:

run :

old=ants.label_geometry_measures( some_labels, some_intensity )
new=ants.label_geometry_measures( some_labels, some_intensity, param=new_filter )
should_be_true( names(old) %in% names(new) )

are they the same? at least conceptually - that's the idea. ie if someone expects to get a variable name - they should get it and it should be correct.

stnava avatar May 03 '24 00:05 stnava

Some of the variables don't exist in the supported filter, but the ones that do are named the same now

cookpa avatar May 03 '24 01:05 cookpa

Further update: I added back eccentricity and Axes length. Got everything except weighted centroid now.

cookpa avatar May 05 '24 13:05 cookpa

#782

cookpa avatar Feb 28 '25 20:02 cookpa