ANTsPy icon indicating copy to clipboard operation
ANTsPy copied to clipboard

Why isn't there a windows version? Compiled whl files

Open 464hee opened this issue 3 years ago • 7 comments
trafficstars

I think the tool is good, but it's too hard to install under Win10

464hee avatar Sep 07 '22 16:09 464hee

pip install https://github.com/SGotla/ANTsPy/releases/download/0.1.7Win64/antspy-0.1.7-cp37-cp37m-win_amd64.whl

I found a solution in my previous question.Thank him for his dedication

464hee avatar Sep 08 '22 03:09 464hee

It would be nice to have the latest version

464hee avatar Sep 08 '22 03:09 464hee

You’re right. However, we don’t have windows machines so it’s difficult for us to support that platform.

ntustison avatar Sep 08 '22 03:09 ntustison

You’re right. However, we don’t have windows machines so it’s difficult for us to support that platform.

You can use the cloud platform to achieve the windows environment testing

464hee avatar Sep 08 '22 03:09 464hee

If you were so inclined, that would be a much appreciated contribution.

ntustison avatar Sep 08 '22 03:09 ntustison

@ntustison I see the wheels.yml seems to have windows builds and recent CI builds on github contain the wheels in the artifacts. Are you planning to push any of those to pypi?

BTW: the ITK external modules use a github action like this. This zips the different platform versions as separate artifacts and if the push/pull_request is tagged with something starting with "v" (e.g. v1.2.3) it is uploaded to pypi.

dyollb avatar Sep 29 '22 13:09 dyollb

the wheels are too big to push all to pypi ... we have limited storage there. also, I don't think anyone has actually tested the windows wheels.

stnava avatar Sep 29 '22 13:09 stnava

What are the sticking points/blockers in building windows wheels? I may want to look into trying to build them. Anything I need to know? Any guidance that would benefit me?

kchawla-pi avatar Jan 07 '23 23:01 kchawla-pi

BTW Azure Pipelines has robust windows build support and is generous to opensource projects.

kchawla-pi avatar Jan 07 '23 23:01 kchawla-pi

we would like to have windows builds but none of the core developers use or even have access to windows machines ... more critically, no time either.

stnava avatar Jan 07 '23 23:01 stnava

I read that. I am volunteering my time and my windows machine. Would the project be interested? If yes, anything I should know that is not obviously documented, before I start?

kchawla-pi avatar Jan 09 '23 13:01 kchawla-pi

You already have a Windows in the wheels.yml , and are unable to test it and host it on PyPI due to limited size. So it is not a technical bottleneck, but a testing and cloud resource one?

kchawla-pi avatar Jan 09 '23 13:01 kchawla-pi

If you were so inclined, that would be a much appreciated contribution.

If this has not been worked on, I will take a look.

kchawla-pi avatar Jan 09 '23 13:01 kchawla-pi

that's great and much appreciated. I don't think the windows release actually works .... some testing would be good .... eg run the examples or something .... we could also use updated documentation of how one might compile on windows. @cookpa any thoughts on this?

stnava avatar Jan 09 '23 13:01 stnava

Cool! Also, if I use Azure Pipelines instead of Appveyor, would that fly with the project?

The Nilearn project used to use Appveyor, and it was pretty limited so I switched it to Azure Pipelines when I was working for Nilearn, and we were much happier for it.

kchawla-pi avatar Jan 09 '23 13:01 kchawla-pi

yes - we are happy to have any help - very thankful ...

stnava avatar Jan 09 '23 13:01 stnava

Thank you all for your excellent work for all of us.

kchawla-pi avatar Jan 09 '23 13:01 kchawla-pi

This sounds great. I don't use Windows, but I have done a bit of work on the CI / deployment through Github actions for other platforms. I'm happy to help where I can.

There have been a few contributors who helped with cross-platform builds: @ravnoor and @tfmoraes - no pressure, I'm just tagging in case of interest in this issue in any capacity.

Anyone else reading this who would be interested in helping develop or use Windows builds, please join in this thread.

cookpa avatar Jan 09 '23 17:01 cookpa

I tested on Windows when I submitted the PR to use the Github CI to generate the Wheels. It's running on Windows, but registration and other parts were not running, see https://github.com/ANTsX/ANTsPy/pull/345#issuecomment-1083562841

tfmoraes avatar Jan 11 '23 18:01 tfmoraes

Thanks for all the wheel building help, the last step was the pointer parsing in ANTs. It should work as of #442

cookpa avatar Mar 23 '23 13:03 cookpa

Oh great! When will this see a release?

On Thu, Mar 23, 2023, 09:01 Philip Cook @.***> wrote:

Thanks for all the wheel building help, the last step was the pointer parsing in ANTs. It should work as of #442 https://github.com/ANTsX/ANTsPy/pull/442

— Reply to this email directly, view it on GitHub https://github.com/ANTsX/ANTsPy/issues/398#issuecomment-1481155426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6SXRBXMO7YQNNX6N3W2S3W5RCSFANCNFSM6AAAAAAQG5DOIQ . You are receiving this because you commented.Message ID: @.***>

kchawla-pi avatar Mar 23 '23 13:03 kchawla-pi

Within a week - probably

On Thu, Mar 23, 2023 at 9:26 AM Kshitij Chawla @.***> wrote:

Oh great! When will this see a release?

On Thu, Mar 23, 2023, 09:01 Philip Cook @.***> wrote:

Thanks for all the wheel building help, the last step was the pointer parsing in ANTs. It should work as of #442 https://github.com/ANTsX/ANTsPy/pull/442

— Reply to this email directly, view it on GitHub https://github.com/ANTsX/ANTsPy/issues/398#issuecomment-1481155426, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB6SXRBXMO7YQNNX6N3W2S3W5RCSFANCNFSM6AAAAAAQG5DOIQ

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/ANTsX/ANTsPy/issues/398#issuecomment-1481191719, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPE7USSEGGFHJGQZEC4WLW5RFOPANCNFSM6AAAAAAQG5DOIQ . You are receiving this because you commented.Message ID: @.***>

--

brian

stnava avatar Mar 23 '23 15:03 stnava

https://pypi.org/project/antspyx/0.3.8/#files

note the long-awaited windows wheels @dorianps thanks to @cookpa ... hoping these continue to work for ppl.

his solution will also enable windows builds for ANTsR .... (eventually)

stnava avatar Mar 23 '23 19:03 stnava

Thank you for your work

464hee avatar Mar 24 '23 01:03 464hee

Thanks for the heads up @stnava/ANTs @.***> and @cookpa. I can try to spread the word if ANTsR becomes available on Windows. People who use lesymap and Linda may be interested.

On Thu, Mar 23, 2023, 9:17 PM 464hee @.***> wrote:

Thank you for your work

— Reply to this email directly, view it on GitHub https://github.com/ANTsX/ANTsPy/issues/398#issuecomment-1482119814, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACFJU7I2E6WTDDBAQ3XS6STW5TYZ3ANCNFSM6AAAAAAQG5DOIQ . You are receiving this because you were mentioned.Message ID: @.***>

dorianps avatar Mar 24 '23 04:03 dorianps