Minor side effect with unauthenticated repair feature

Open extiop opened this issue 10 months ago • 0 comments

Fails like https://github.com/ANSSI-FR/MLA/actions/runs/12364423067/job/34507635501?pr=227 and https://github.com/ANSSI-FR/MLA/actions/runs/12364423067/job/34507634605?pr=227 are most likely explained by https://github.com/ANSSI-FR/MLA/issues/226 and https://github.com/ANSSI-FR/MLA/blob/master/mlar/tests/integration.rs#L43. Indeed, when file3.bin from the setup() is used in test_repair_auth_unauth() integration test, the input to mlar is 10 bytes and brotli fails to read it correctly as explained in the issue. Thereby, it fails the test as unauthenticated read data is equal to authenticated read data, which is 0, failing here https://github.com/ANSSI-FR/MLA/blob/master/mlar/tests/integration.rs#L544.

Thus, the feature (unauthenticated and authenticated data from repair cf. https://github.com/ANSSI-FR/MLA/pull/222) works well but fixing this side problem is preferable.

First identified there: https://github.com/ANSSI-FR/MLA/pull/227#issuecomment-2547321575

Linked to https://github.com/ANSSI-FR/MLA/issues/226

Mar 02 '25 17:03 extiop