Adrien Montagu

Accept filters from request arguments and not only metadata

2

In DSG metadata is what used to replace the query parameters systems. It is very flexible as it's not in the proto file. The main inconvenients are: * The metadata...

Adding a Django-filters widget or class override to allow passing a list instead of a csv formated string for fitlers

2

As Django filters is based on query params it only support string format and then convert it. As DSG use gRPC we can pass more complex type. It could be...

Improve shared library doc

1

@markdoerr I put back your comment in this PR to discuss more about it in the future

``` class DepositImageProtoSerializer(proto_serializers.ModelProtoSerializer): deposit = serializers.PrimaryKeyRelatedField( queryset=Deposit.objects.all(), pk_field=UUIDField(format="hex_verbose"), allow_null=True, required=False, ) image = Base64ImageField(allow_null=True) class Meta: model = DepositImage proto_class = product_pb2.DepositImageResponse proto_class_list = product_pb2.DepositImageListResponse fields = [ "uuid", "deposit",...

Adding more Datatype in the proto generation

1

The goal is to make DSG more compatible with the proto3 features such as: - Map - Enum - Oneof - Reserved Map - https://protobuf.dev/programming-guides/proto3/#maps: - grpc action - DictField...

We are handling rest framework APIException subclass natively now. In the doc https://www.django-rest-framework.org/api-guide/exceptions/ it's also refer to permission denied et 404 base django exception. Need to verify that we are...

https://grpc.github.io/grpc/python/grpc_asyncio.html#grpc.aio.server Only needed for sync or migration purpose. Will be good to set it to None and remove command argument max-workers.

this code in proto_serializers.py: ``` repeated_message = getattr(message, message_list_attr, "") if not isinstance(repeated_message, MutableSequence): error_message = self.default_error_messages["not_a_list"].format( # TODO not working anymore for custome input_type input_type=repeated_message.__class__.__name__ ) raise ValidationError( {api_settings.NON_FIELD_ERRORS_KEY:...

The parameter to_root_grpc of AppHandlerRegistry may lead to issue if not used with external librairie Think about automatize it or add a warning if we can detect it

Think about how improve AppHandlerRegistry and document it

1

AppHandlerRegistry interface may be improved in term of usage. But all this magic behavior should also be explained/documented so people that know how grpc python work understand the way DSG...