is-05 icon indicating copy to clipboard operation
is-05 copied to clipboard

sender-stage-success.json does not match Schema activation-response-schema.json

Open kierank opened this issue 1 year ago • 3 comments

The example Sender Stage Succes https://specs.amwa.tv/is-05/releases/v1.1.2/examples/sender-stage-success.html does not match the Schema https://specs.amwa.tv/is-05/releases/v1.1.2/APIs/schemas/resolved/sender-response-schema.html for "activation-time".

https://specs.amwa.tv/is-05/releases/v1.1.2/examples/sender-stage-success-redundant-streams.html has the same issue.

kierank avatar Nov 01 '23 18:11 kierank

Thanks, @kierank. Specifically, these examples do not comply with the sentence "For immediate activations on the staged endpoint this property [activation_time] will be the time the activation actually occurred in the response to the PATCH request".

garethsb avatar Nov 01 '23 18:11 garethsb

In relation to this, the /staged endpoints are missing example JSON for a GET request after an immediate activation took place. "receiver-stage-success" is what the receiver's /staged endpoint should return in response to a PATCH request. "receiver-stage-scheduled-" is the result of a GET request on the /staged endpoint whilst an activation is pending. But there isn't one for GET /staged following an immediate activation (equivalent to receiver-active-get-200)

Or is this it? https://specs.amwa.tv/is-05/releases/v1.1.2/examples/sender-get-200.html

matthewdicken avatar Nov 03 '23 15:11 matthewdicken

Also, the descriptions in the activation response schema talk specifically about the response and /staged endpoint, but with no mention of the /active endpoint. One could infer that the wording "will be null in response to any subsequent GET requests" might also apply to the /active endpoint, but these both need to be set in order to pass IS-05 test_25, whereas currently the requested_time must be set to NULL in order to pass, even though the example shows the field as populated.

https://specs.amwa.tv/is-05/releases/v1.1.2/APIs/schemas/with-refs/activation-response-schema.html https://specs.amwa.tv/is-05/releases/v1.1.2/examples/sender-active-get.html

matthewdicken avatar Nov 14 '23 11:11 matthewdicken