AMReX-Codes
CMake: 3.25+
Summary
We already use features of FindCUDAToolkit for nvtx3 that are CMake 3.25+. Modernize and remove pre CMake 3.20 CUDA logic.
Additional background
CMake 3.25 was released in November 2022 and is widely available and very easy to install as a user, if missing.
Also a bit of prep for #4572
As in WarpX, we disable SENSEI CI because the package has gone unsupported and deprecated for a few years now.
Checklist
The proposed changes:
- [ ] fix a bug or incorrect behavior in AMReX
- [ ] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX users
- [ ] include documentation in the code and/or rst files, if appropriate
@WeiqunZhang can you please remove SENSEI Adaptor [test] from the required tests in CI?
Should we also update this? https://github.com/AMReX-Codes/amrex/blob/e7271974e848bb3a472b7230e88a1ceac9fe247a/Tools/CMake/AMReXCUDAOptions.cmake#L61
Also don't think we need to worry about CUDA 10 anymore.
Yes, couple of options we need to refresh now.
E.g., add support for LTO on AMReX_CUDA_LTO.
Supported by CMake 3.25+, too: https://cmake.org/cmake/help/latest/module/CheckIPOSupported.html