amrex icon indicating copy to clipboard operation
amrex copied to clipboard

Fixed grids allows you to violate your own inputs.

Open drummerdoc opened this issue 4 years ago • 2 comments

Since the beginning of time, we have allowed the specification of a fixed grids, but this assumes that you "know what you're doing". Sometimes, I clearly don't :), and screw up by giving grids that don't satisfy the inputs. I wonder if it makes sense to add an option that "fixes" up the grids according to an understood set of rules to do things like ensure proper nesting, max_grid_size and blocking factor. Just a thought...

drummerdoc avatar Jun 23 '20 17:06 drummerdoc

I would recommend aborting rather than fixing the grids -- but I agree that the user needs to be made aware their inputs are inconsistent

On Tue, Jun 23, 2020 at 10:49 AM Marc Day [email protected] wrote:

Since the beginning of time, we have allowed the specification of a fixed grids, but this assumes that you "know what you're doing". Sometimes, I clearly don't :), and screw up by giving grids that don't satisfy the inputs. I wonder if it makes sense to add an option that "fixes" up the grids according to an understood set of rules to do things like ensure proper nesting, max_grid_size and blocking factor. Just a thought...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AMReX-Codes/amrex/issues/1046, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRE6YQYVAAVIEBYMY3JA5LRYDTJFANCNFSM4OF4UN3Q .

-- Ann Almgren Senior Scientist; CCSE Group Lead

asalmgren avatar Jun 23 '20 18:06 asalmgren

That certainly would be easier to implement and describe.

drummerdoc avatar Jun 23 '20 18:06 drummerdoc