Microphysics
Microphysics copied to clipboard
for simplified SDC, if T is outside of range do we still need to include advective terms?
In vode_rhs_simplified_sdc.H
, we have a check:
if (state.T <= EOSData::mintemp || state.T >= MAX_TEMP) {
for (int n = 1; n <= VODE_NEQS; ++n) {
ydot(n) = 0.0_rt;
}
return;
}
but I am not sure we should just return here -- don't we need to add the advective terms in this case (which is done in rhs_to_vode
)?
It's really not good we do the ydot = 0 thing. Instead, now that we're not integrating T, we could just floor or ceiling the temperature to mintemp or maxtemp and then evaluate the rates with that temperature.