Microphysics icon indicating copy to clipboard operation
Microphysics copied to clipboard

switch Strang integration to work with (rho X, rho e)

Open zingale opened this issue 1 year ago • 3 comments

Right now Strang integrates (X, e) and SDC integrates (rho X, rho e). We should sync them.

algebraically, since rho is constant in Strang integration, this should not affect things much (except how atol is interpreted). But it will make code reuse between SDC and Strang much easier.

zingale avatar May 31 '23 17:05 zingale

maybe the way to do this is to have the state always come in via burn_t burn_state.y[]. But for Strang we don't need to include the momenta or the advective terms.

zingale avatar Jun 01 '23 19:06 zingale

Seems to me like we should just aim to use the SDC integrator for Strang with the advective terms set to zero.

maxpkatz avatar Jun 04 '23 19:06 maxpkatz

yes. I think that's a good idea. We can constexpr them out too

zingale avatar Jun 04 '23 19:06 zingale