Castro icon indicating copy to clipboard operation
Castro copied to clipboard

split c-linter action in 2

Open zingale opened this issue 4 months ago • 2 comments

Right now the c-linter action does clang-tidy and claims to do cppcheck. We should split it in two.

For the clang-tidy, we should use the build process that is in AMReX currently (USE_CLANG_TIDY=TRUE).

For cppcheck, we should make sure it is actually running and make an artifact from the output.

zingale avatar Feb 09 '24 15:02 zingale

One of the considerations is that cppcheck uses a compilation database to pick up the right options and files. It might be possible to do something with make print-CXXFLAGS etc instead, but I'm not sure.

yut23 avatar Feb 20 '24 18:02 yut23

we now have a separate clang-tidy action, so I am not sure if we even need this one anymore.

zingale avatar Apr 22 '24 18:04 zingale