Castro icon indicating copy to clipboard operation
Castro copied to clipboard

[WIP] clean-up the transverse flux correction

Open zingale opened this issue 3 years ago • 1 comments

PR summary

The transverse flux correction is done to the conserved interface state variables after we do the normal interface prediction. Previously we were doing a transverse correction on p in order to have enough of a thermodynamic state to get back the primitive state after the correction. Now we instead just work with the conserved state and call the EOS at the end to ensure consistency.

As part of this change, we now do the dual energy formulation consistent with how it is done in ctoprim.

This also fixes an issue with the reset of the state if rho < 0 -- we were not resetting the passives in this case.

PR motivation

PR checklist

  • [ ] test suite needs to be run on this PR
  • [ ] this PR will change answers in the test suite to more than roundoff level
  • [ ] all newly-added functions have docstrings as per the coding conventions
  • [ ] the CHANGES file has been updated, if appropriate
  • [ ] if appropriate, this change is described in the docs

zingale avatar Jun 25 '21 01:06 zingale

this seems to result in a lot of (rho e) resets in the Riemann solver.

zingale avatar May 11 '22 16:05 zingale