AMICI
AMICI copied to clipboard
Add downstream test for pypesto
Add downstream tests of tools that depend on AMICI and for which we want to ensure near-continuous compatibility (e.g. pyPESTO). These tests are not expected to pass, but can inform when AMICI changes can lead to problems downstream.
Codecov Report
Merging #1862 (8afd3d1) into develop (9c36029) will increase coverage by
0.01%
. The diff coverage isn/a
.
Additional details and impacted files
@@ Coverage Diff @@
## develop #1862 +/- ##
===========================================
+ Coverage 76.14% 76.16% +0.01%
===========================================
Files 74 74
Lines 12858 12858
===========================================
+ Hits 9791 9793 +2
+ Misses 3067 3065 -2
Flag | Coverage Δ | |
---|---|---|
cpp | 72.87% <ø> (+0.02%) |
:arrow_up: |
petab | 58.86% <ø> (ø) |
|
python | 68.54% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/sundials_matrix_wrapper.cpp | 81.02% <0.00%> (+0.40%) |
:arrow_up: |
Marking as allow-failure
appears not possible yet https://github.com/community/community/discussions/15452
Not convinced that this is necessary or desired. AMICI API is pretty stable and we are pretty consistent in maintaining downstream compatibility. The issue in https://github.com/ICB-DCM/pyPESTO/issues/924#issuecomment-1234777385 was a result of abusing the API.
I don't think we should add downstream tests here. I'd say, there should rather be a test with amici@develop in pypesto.
Ok!