Python splines

Open paulstapor opened this issue 3 years ago • 5 comments

This one is to replace #1245. However, it seems like in the long time of divergence, there were changes to functions from sbml_import, that may be not captured, as these functions have been moved out of sbml_import.py to sbml_utils.py on the python_splines branch... It looks like automatic merge of these files did not do completely the right thing... So, we have to be careful about functions that have been moved to newly created files, it seems...

Jun 17 '21 15:06 paulstapor

ping @lcontento

Nov 05 '21 10:11 dweindl

Codecov Report

Merging #1515 (e2c60c6) into develop (8610559) will decrease coverage by 8.86%. The diff coverage is 37.68%.

@@             Coverage Diff             @@
##           develop    #1515      +/-   ##
===========================================
- Coverage    78.75%   69.89%   -8.87%     
===========================================
  Files           69       70       +1     
  Lines        10734    12082    +1348     
===========================================
- Hits          8454     8445       -9     
- Misses        2280     3637    +1357

Flag	Coverage Δ
cpp	`74.27% <61.94%> (-0.97%)`	:arrow_down:
petab	`?`
python	`59.79% <22.17%> (-8.48%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
include/amici/abstract_model.h	`0.00% <ø> (ø)`
include/amici/model.h	`60.86% <ø> (ø)`
python/amici/gradient_check.py	`85.86% <ø> (ø)`
python/amici/petab_import.py	`7.01% <ø> (-64.04%)`	:arrow_down:
src/spline.cpp	`65.26% <ø> (ø)`
python/amici/splines.py	`17.19% <17.19%> (ø)`
python/amici/sbml_utils.py	`22.98% <22.98%> (ø)`
include/amici/splinefunctions.h	`33.33% <33.33%> (ø)`
python/amici/ode_export.py	`90.77% <54.68%> (-2.84%)`	:arrow_down:
src/splinefunctions.cpp	`58.31% <58.31%> (ø)`
... and 16 more