AMICI icon indicating copy to clipboard operation
AMICI copied to clipboard

Failing Matlab test

Open dweindl opened this issue 3 years ago • 0 comments

Originally posted by @FFroehlich in https://github.com/AMICI-dev/AMICI/issues/1451#issuecomment-794872534

Reports missed expectations, but does not fail. Currently, '/model_steadystate/sensifwdbyhandpreeq' reports wrong sx0, sx, sy and sllh, independently of these changes.

That's one of the few tests where sx0 is specified in the options. In fact, I think /model_steadystate/sensifwdbyhandpreeq is the only other test that uses this option and it also fails the test for sx0 and sllh. It looks like the matlab interface uses setInitialStateSensitivities while the cpp HDF5 reader uses setUnscaledInitialStateSensitivities to pass this to the model.

Looks like I changed the behaviour in the cpp HDF5 reader in https://github.com/AMICI-dev/AMICI/commit/5830fbdca6acc1f0f57b3f3f54cf4d70ebbe4a24 where I also updated the matlab wrapper and removed the unscale. I would have to think more carefully about this, but it looks like I simply forgot to also change the respective call in the matlab interface.

Once this is fixed, the Matlab testsuite on GHA should be changed to fail if expectations aren't met.

dweindl avatar Mar 10 '21 09:03 dweindl