AMICI icon indicating copy to clipboard operation
AMICI copied to clipboard

Add test case comparing -O3 model simulation with -O2

Open dweindl opened this issue 4 years ago • 3 comments

Would be good to add a test case comparing simulation results from -O3 compiled model to those from -O2 for a non-trivial model. For repeated simulations during parameter estimation, -O3 is clearly preferably, but may lead to issues when relying on undefined behavior or due to compiler bugs.

dweindl avatar Jun 10 '20 10:06 dweindl

Static analysis won't tell us where those issues are? If things work for -O3 (which is the default, right?) shouldn't they also work for -O2?

FFroehlich avatar Jun 12 '20 17:06 FFroehlich

Static analysis won't tell us where those issues are?

Everything besides compiler issues probably yes.

If things work for -O3 (which is the default, right?) shouldn't they also work for -O2?

If O3 is right, then O2 should be as well. But we are running tests on debug builds, don't we?

dweindl avatar Jun 14 '20 16:06 dweindl

Static analysis won't tell us where those issues are?

Everything besides compiler issues probably yes.

If things work for -O3 (which is the default, right?) shouldn't they also work for -O2?

If O3 is right, then O2 should be as well. But we are running tests on debug builds, don't we?

Oh, good point!

FFroehlich avatar Jun 15 '20 15:06 FFroehlich