Anders Jenbo comments

Results 1104 comments of


                                            Anders Jenbo

Bump code style to PSR-12 for phpcs

Thanks, glad not to be carrying this one anymore

Broken test due to switch between for UnusedLocalVariable & UnusedFormalParameteter Detection for Inner Functions

Already fixed here: https://github.com/phpmd/phpmd/pull/1139 The tests are correct, the inner functions contain properties with the same name, but they do not belong to the outter function.

Broken test due to switch between for UnusedLocalVariable & UnusedFormalParameteter Detection for Inner Functions

I believe this has been fixed

PHP 8.1 Enums static methods support

> But with the limited possibilities (handling legacy code that is not strongly typed) we are currently unable to accurately detect if a method is actually such an acceptable case...

PHP 8.1 Enums static methods support

Arh i was thinking we could do it specifically for the enum class

phpmd.phar inclusion via other PHP script is impossible

Please correct the license information for the package.

phpmd.phar inclusion via other PHP script is impossible

Nice work :clap: It's a nice project and I can see it being helpful.

LevelCelView: Changing height of tiles should be foolproof

11 would cover the screen height so probably just cap it at 10, or there a bout. Roughly 112 would cover the entire height of the level. I'm not even...

Correct argument types

nice, it's good to have this in while i work on phpmd :)

Convert PHPDoc to return type hints

> I wonder how we can proceed such refactors dealing with conflicts. I guess we should do them by chunk (limited number of folders or files). They are the last...