FinRL icon indicating copy to clipboard operation
FinRL copied to clipboard

There is a problem with the buy and sell operation in the env_stocktrading_np file

Open dd-python opened this issue 1 year ago • 4 comments

When tested with the env_stocktrading_np environment, the action to sell the stock does not take into account whether the stock is currently held

dd-python avatar Apr 30 '23 09:04 dd-python

we have not updated it. pls use env_stocktrading.py

zhumingpassional avatar May 02 '23 01:05 zhumingpassional

Thank you for your reply

------------------ 原始邮件 ------------------ 发件人: "Ming @.>; 发送时间: 2023年5月2日(星期二) 上午9:17 收件人: @.>; 抄送: @.>; @.>; 主题: Re: [AI4Finance-Foundation/FinRL] There is a problem with the buy and sell operation in the env_stocktrading_np file (Issue #994)

we have not updated it. pls use env_stocktrading.py

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

dd-python avatar May 07 '23 14:05 dd-python

we have not updated it. pls use env_stocktrading.py

ElegantRL only works with env_stocktrading_np so I have done all the work with env_stocktrading_np. Is it wrong?

Thanx.

julianzero avatar May 16 '23 08:05 julianzero

we have not updated it. pls use env_stocktrading.py

I have revised env_stocktrading_np, and firmly believe it is correct.

env_stocktrading.py involves too many parameters, can you give an example of the input arguments?

Thanx.

julianzero avatar May 16 '23 10:05 julianzero