FinRL icon indicating copy to clipboard operation
FinRL copied to clipboard

Why don't Notebook results match paper results - NeurIPS 2018

Open benstaf opened this issue 1 year ago • 3 comments

The NeurIPS 2018 paper Practical Deep Reinforcement Learning Approach for Stock Trading announces that RL is better that DJIA index:

Screenshot_2024-12-27-22-04-20-341_com google android apps docs-edit

However, the notebook doesn't reproduce the result: https://github.com/AI4Finance-Foundation/FinRL/blob/master/examples/Stock_NeurIPS2018_3_Backtest.ipynb download (1)

Why?

benstaf avatar Dec 27 '24 21:12 benstaf

Hello @benstaf I think research paper result is trained on different time period for dji and notebook mentioned in the GitHub is trained for different period, can you match the period and hyperparameter as discussed in paper. You might see similar results.

Let me know if I did wrong interpretation of your issue or any thing else.

krishdotn1 avatar Dec 31 '24 19:12 krishdotn1

Thanks, but in the paper I didn't find the hyperparameters used

benstaf avatar Jan 01 '25 08:01 benstaf

the question is, why trying to make finrl works when FinRL_Podracer is in da place !

aymeric75 avatar Feb 10 '25 22:02 aymeric75