maxtext icon indicating copy to clipboard operation
maxtext copied to clipboard

[tools/setup/setup.sh] Nightly cleanup

Open SamuelMarks opened this issue 1 month ago • 1 comments

Description

[tools/setup/setup.sh] Cleanup redundant and unnecessary nightly dependencies ; use --no-deps ; minor other cleanup / DRYness

Tests

CI and manual:

$ bash ./dependencies/scripts/docker_build_dependency_image.sh DEVICE='tpu' MODE='nightly'
$ bash ./dependencies/scripts/docker_build_dependency_image.sh DEVICE='tpu' MODE='stable'

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • [x] I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • [x] I have necessary comments in my code, particularly in hard-to-understand areas.
  • [x] I have run end-to-end tests tests and provided workload links above if applicable.
  • [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

SamuelMarks avatar Nov 14 '25 21:11 SamuelMarks

Thanks Samuel. Could you please also run a training for both of the MODE options being updated here? As well as with/without explicitly setting JAX_VERSION?

It would also be good to pip show that the versions are what you would expect for each build

bvandermoon avatar Nov 14 '25 22:11 bvandermoon

Thanks Samuel. Could you please also run a training for both of the MODE options being updated here? As well as with/without explicitly setting JAX_VERSION?

It would also be good to pip show that the versions are what you would expect for each build

@SamuelMarks - Can you also test the setup when MODE and JAX_VERSION are specified?

SurbhiJainUSC avatar Dec 04 '25 00:12 SurbhiJainUSC

Comments will be addressed as part of https://github.com/AI-Hypercomputer/maxtext/pull/2833. Closing this PR.

SurbhiJainUSC avatar Dec 15 '25 21:12 SurbhiJainUSC