Andrew Ayer

Results 106 comments of Andrew Ayer

`DecodeChains` should not use `convertAttribute`, which is a helper function for the deprecated `ToPEM`. Instead let's just write a new function that extracts only the friendly name and ignores all...

> So the FriendlyName in the Chain is the friendly name of the private key, and thus friendly names of the certificates are to be discarded? Yeah, I think this...

I verified that GCC 12 with `-O2` produces the same assembly code for `byte_counter++ & (BLOCK_LEN -1)` as `byte_counter++ % BLOCK_LEN`. This is trivial optimization that I'd expect all modern...

Your version of Go is probably too old; the `toolchain` directive was introduced in Go 1.21.

Community help wanted: a pull request that adds a GitHub workflow (similar to existing workflows for Linux and Windows) that builds git-crypt for macOS. Third-party reusable actions (those not in...

Why send a notification for a certificate with a known key? How would you respond to such a notification?

1. I think being able to filter legitimate certificates by public key hash is a good feature and plan to add it to a future version of certspotter. 2. Providing...

> No. #97 would be no alternative for me. Could you explain why not? > You mean that I ignore the certspotter mail sending feature completely and send my own...

Thanks for expanding on that. It sounds useful and I agree that #97 wouldn't solve it. Your PR includes the ability to name keys. What's the purpose of that?