pouchdb.d.ts
pouchdb.d.ts copied to clipboard
Missing replicate and sync function
Hi, I can't find replicate and sync functions in the definition. Thanks Math
PS: good job :+1: I vote for add this definition to DefinitelyTyped
Hello @mfilotto. Thank you for the issue report (have you seen borisyankov/DefinitelyTyped#4328)?
I didn't get as far as these two methods in the initial sprint, unfortunately. I will take a look at it in the next month or so, but if you fancy submitting a PR † before then I'll always review/merge it.
† The dev approach for pouchdb.d.ts is outlined here. So for these functions we would need to identify all the pouchdb tests that refer to sync
and replicate
, and then iterate writing those tests in ts, and updating the d.ts to allow that to happen, until we mimic the all the relevant pouchdb tests.
Hi @AGBrown, Thanks for you answer. I work on a PR ASAP.
wip...
I added 'replicate' in my PR show #36
@mfilotto did you get anywhere with your PR? If you did then it would be good to see what you have, even if incomplete, so we can compare it with the work by @sebglon and check we aren't going missing any considerations.
@AGBrown sorry Andrew, I'm very busy these days so no progress on my side. Thanks to @sebglon for his work that will be very usefull
Do your pouchdb definition be pushed in DefinitelyTyped soon ? I hope so
I added replicate.to to my fork. Going to work on sync method aswell.