ARVideoKit icon indicating copy to clipboard operation
ARVideoKit copied to clipboard

Not supported for an iPad application

Open senthilece01 opened this issue 6 years ago • 8 comments

Hi team,

The video and photo capture are supporting only for iPhone application. It doesn't support for iPad application. The video looks very stretched.

Kindly fix this and update it for iPad too.

senthilece01 avatar Dec 19 '17 13:12 senthilece01

@senthilece01, thank you for informing me about this issue.

I have actually found that issue recently and I'm working on a fix!

-Ahmed

AFathi avatar Dec 19 '17 19:12 AFathi

Thank you @AFathi . Kindly update here once you fix the issues.

senthilece01 avatar Dec 20 '17 18:12 senthilece01

@senthilece01,

Of course, will do!

-Ahmed

AFathi avatar Dec 20 '17 19:12 AFathi

Any update ? Have you fixed it ?

senthilece01 avatar Feb 12 '18 00:02 senthilece01

@senthilece01,

I wasn't able to confirm whether the fix works or not since I don't have access to any ARKit-supported iPad. However, I can share with you where I think the issue the coming from so you edit the source code and test it.

So, I believe the main issue is coming from the way I'm scaling the rendered frame. I'd suggest to take a look at the bufferSize object in the ARVideoKit/Rendering/RenderAR.swift file. Try changing the width and height by checking whether the device is iPad or not.

screen shot 2018-02-11 at 8 01 24 pm

It would be greatly appreciated if you fix it and create pull request to this repository.

-Ahmed

AFathi avatar Feb 12 '18 01:02 AFathi

@senthilece01, Can you also please send a screenshot of how the video looks like after exporting?

AFathi avatar Feb 12 '18 01:02 AFathi

@AFathi Please check the below image. It looks very stretched after captured the photo in an iPad.

img_0367 2

senthilece01 avatar Feb 12 '18 03:02 senthilece01

is it done ?

senthilece01 avatar Mar 27 '18 12:03 senthilece01