qemuafl icon indicating copy to clipboard operation
qemuafl copied to clipboard

Fix parent refcount (huge memory leak) on non-last thread exit

Open kotee4ko opened this issue 1 year ago • 7 comments

fix it plz

kotee4ko avatar Jun 17 '23 01:06 kotee4ko

how do you get to these changes? Is that a backport from a new qemu version? I cannot blindly accept a PR, and I do not have the necessary background on such qemu specifics - nor the time - to evaluate that.

vanhauser-thc avatar Jun 20 '23 17:06 vanhauser-thc

how do you get to these changes? Is that a backport from a new qemu version?

No, it is not.

kotee4ko avatar Jun 22 '23 10:06 kotee4ko

@andreafioraldi you know the code much better (or - at all - ) than me. can you react to @kotee4ko 's replies? thank you!

vanhauser-thc avatar Jul 02 '23 10:07 vanhauser-thc

@andreafioraldi ?

vanhauser-thc avatar Sep 21 '24 06:09 vanhauser-thc

@andreafioraldi ?

I'll look at it on monday

andreafioraldi avatar Sep 21 '24 08:09 andreafioraldi

This is a QEMU bug, not related to qemuafl, it is now fixed https://gitlab.com/qemu-project/qemu/-/issues/866

IMO we should simply cherry-pick the commits and backport to qemuafl. Please in case of bugs in QEMU report them upstream not to us.

Il giorno sab 21 set 2024 alle ore 08:35 van Hauser < @.***> ha scritto:

@andreafioraldi https://github.com/andreafioraldi ?

— Reply to this email directly, view it on GitHub https://github.com/AFLplusplus/qemuafl/pull/51#issuecomment-2365028367, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3LJ6WLKEE5CUQKDIMTTZTZXUHU5AVCNFSM6AAAAABOTJ4U2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGAZDQMZWG4 . You are receiving this because you were mentioned.Message ID: @.***>

andreafioraldi avatar Sep 23 '24 19:09 andreafioraldi

@kotee4ko I agree, cherry picking fix commits is better, it will it more likely that future cherry picked fix commits can be applied too easily. do you want to do that?

vanhauser-thc avatar Sep 24 '24 07:09 vanhauser-thc