LibAFL icon indicating copy to clipboard operation
LibAFL copied to clipboard

WIP Add Intel PT tracing support

Open Marcondiro opened this issue 1 year ago • 4 comments

WIP, any feedback is welcome

Marcondiro avatar Aug 02 '24 15:08 Marcondiro

I'll rebase on this before making libafl_qemu changes in #2438.

addisoncrump avatar Aug 04 '24 22:08 addisoncrump

What's the benefit of the perf-event-open-sys crate thingy over bindgen? Just double checking / asking stupid questions :)

domenukk avatar Aug 05 '24 16:08 domenukk

No worries :) It has a couple of syscall/ioctl wrappers already available and it addresses an issue I had with Bindgen and #defines. They solved it already in their wrapper.h adding an enum. Let me know if you want me to go deeper than this answer :D

Marcondiro avatar Aug 05 '24 17:08 Marcondiro

Nah sounds good, it's just always good to double-check if new crates are necessary. If it solves issues let's gooo

domenukk avatar Aug 05 '24 17:08 domenukk

If we're to release 0.14 soon, can we merge (part of) this PR already? At least the stuff that changes existing APIs would probably be good to have

domenukk avatar Oct 23 '24 08:10 domenukk

@domenukk yep sure, I will clean up the code a bit and let you know when it is reviewable

Marcondiro avatar Oct 23 '24 08:10 Marcondiro

Hello @rmalmain @domenukk, if you wish you could start to have a look at the new code in libafl_bolts (interface to intelPT usable in both libafl and libafl_qemu) and at the IntelPT executor hook. Also the babyfuzzer should be kinda ready.

I'm still working on cleaning the commandExecutor (and the fuzzer built on top of it), it might be removed from this PR depending on the 0.14 cutoff date thanks!

Marcondiro avatar Oct 29 '24 10:10 Marcondiro

Can you merge main?

domenukk avatar Nov 06 '24 15:11 domenukk

I am waiting for this https://github.com/AFLplusplus/LibAFL/pull/2652 to be reverted...

Marcondiro avatar Nov 06 '24 15:11 Marcondiro

Also, any chance we can merge this today or tomorrow for 0.14?

domenukk avatar Nov 11 '24 18:11 domenukk

@domenukk I think I've addressed every comment

Marcondiro avatar Nov 12 '24 10:11 Marcondiro

ok on my side. let's merge @domenukk ?

rmalmain avatar Nov 12 '24 10:11 rmalmain

Again to the bitbybit, I am not against it at all, but we shoudn't have two dependencies for the same use case - so we need to change the other usage to bitbybit

domenukk avatar Nov 13 '24 01:11 domenukk

Great work btw! :)

domenukk avatar Nov 13 '24 01:11 domenukk