LibAFL icon indicating copy to clipboard operation
LibAFL copied to clipboard

Potential Undefined Behavior in Frida ASan

Open domenukk opened this issue 1 year ago • 1 comments

In asan_rt.rs, we're getting mutable references to self at various places, hereby creating aliases for mutable references. This is not permitted in Rust and may break in the future, see here: https://github.com/AFLplusplus/LibAFL/blob/97a83aba3bc6376786984efde3e4a968fe553068/libafl_frida/src/asan/asan_rt.rs#L1945C42-L1945C46 Instead, we probably need to store the runtime on the heap and keep a pointer to it (Rc, UnsafeCell, Pin, or something like that?)

domenukk avatar Feb 15 '24 15:02 domenukk

True. Needs a major refactor.

s1341 avatar Feb 18 '24 07:02 s1341