AElf icon indicating copy to clipboard operation
AElf copied to clipboard

Add a new whitelist solution

Open chopin-fan opened this issue 1 year ago • 2 comments

For issue #3610 .

Add *, +, - operators to BigIntValue type.

chopin-fan avatar Sep 29 '24 04:09 chopin-fan

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
53.85% gldeng 14 7
30.77% eanzhao 32 4
30.77% ZhangXin 32 4
30.77% jason-hoopox 12 4
30.77% 轩辕焮痕 1 4
23.08% AbigailDeng 1 3

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...test/AElf.OS.Network.Grpc.Tests/AElf.OS.Network.Grpc.Test66.67%2 out of 3 times
test/AElf.OS.Tests/AElf.OS.Tests.csproj66.67%2 out of 3 times
...test/AElf.Kernel.TransactionPool.Tests/AElf.Kernel.Transa66.67%2 out of 3 times
test/AElf.CrossChain.Tests/AElf.CrossChain.Tests.csproj66.67%2 out of 3 times
...test/AElf.Contracts.Genesis.Tests/AElf.Contracts.Genesis.66.67%2 out of 3 times
...test/AElf.Contracts.MultiToken.Tests/AElf.Contracts.Multi66.67%2 out of 3 times
test/AElf.Kernel.Core.Tests/AElf.Kernel.Core.Tests.csproj66.67%2 out of 3 times
...test/AElf.Runtime.CSharp.Tests/AElf.Runtime.CSharp.Tests.66.67%2 out of 3 times
...test/AElf.Contracts.CrossChain.Tests/AElf.Contracts.Cross66.67%2 out of 3 times
...test/AElf.Contracts.Election.Tests/AElf.Contracts.Electio66.67%2 out of 3 times

Committed file ranks

  • 84.98%[...test/AElf.Sdk.CSharp.Tests/CSharpSmartContractContextTest]
  • 82.73%[src/AElf.Runtime.CSharp.Core/ContractCodeLoadContext.cs]
  • 0.00%[test/AElf.Sdk.CSharp.Tests/ed25519_testdata.json]
  • 99.29%[test/AElf.Sdk.CSharp.Tests/AElf.Sdk.CSharp.Tests.csproj]
  • 98.92%[src/AElf.Sdk.CSharp/CSharpSmartContractContext.cs]
  • 98.52%[AElf.All.sln]
  • 0.00%[src/AElf.Sdk.CSharp.Spec/IBuiltIns.cs]
  • 20.52%[src/AElf.Sdk.CSharp.Spec/AElf.Sdk.CSharp.Spec.csproj]
  • 0.00%[src/AElf.Sdk.CSharp.Internal/AssemblyInfo.cs]
  • 79.55%[src/AElf.Sdk.CSharp/CSharpSmartContractAbstract.cs]
  • vizipi[bot] avatar Sep 29 '24 04:09 vizipi[bot]

    Codecov Report

    Attention: Patch coverage is 91.37931% with 10 lines in your changes missing coverage. Please review.

    Project coverage is 73.49%. Comparing base (187d3ed) to head (187a4c5).

    Files with missing lines Patch % Lines
    src/AElf.Sdk.CSharp.Internal/InternalBuiltIns.cs 85.71% 5 Missing :warning:
    ...Ops/Patchers/Module/CallAndBranchCounts/Patcher.cs 84.61% 2 Missing :warning:
    ...ps/Validators/Module/ContractStructureValidator.cs 0.00% 2 Missing :warning:
    src/AElf.Types/Types/BigIntValue.cs 97.05% 1 Missing :warning:
    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3614      +/-   ##
    ==========================================
    + Coverage   73.24%   73.49%   +0.25%     
    ==========================================
      Files         678      679       +1     
      Lines       26209    26316     +107     
      Branches     2364     2371       +7     
    ==========================================
    + Hits        19196    19342     +146     
    + Misses       6857     6818      -39     
      Partials      156      156              
    
    Files with missing lines Coverage Δ
    ...CSharp.CodeOps/Validators/Method/ArrayValidator.cs 95.17% <100.00%> (ø)
    ...CodeOps/Validators/Whitelist/IWhitelistProvider.cs 100.00% <100.00%> (ø)
    ...Application/IExecutionObserverThresholdProvider.cs 100.00% <100.00%> (ø)
    ...Elf.Runtime.CSharp.Core/ContractCodeLoadContext.cs 100.00% <100.00%> (ø)
    src/AElf.Sdk.CSharp/CSharpSmartContractAbstract.cs 100.00% <ø> (ø)
    src/AElf.Sdk.CSharp/CSharpSmartContractContext.cs 76.15% <100.00%> (+3.58%) :arrow_up:
    src/AElf.Types/Types/BigIntValue.cs 63.56% <97.05%> (+63.56%) :arrow_up:
    ...Ops/Patchers/Module/CallAndBranchCounts/Patcher.cs 96.72% <84.61%> (-3.28%) :arrow_down:
    ...ps/Validators/Module/ContractStructureValidator.cs 82.68% <0.00%> (-0.94%) :arrow_down:
    src/AElf.Sdk.CSharp.Internal/InternalBuiltIns.cs 85.71% <85.71%> (ø)

    codecov[bot] avatar Sep 29 '24 04:09 codecov[bot]