AElf icon indicating copy to clipboard operation
AElf copied to clipboard

[WIP] One more code checking during the block validation if the previous code checking was failed.

Open EanCuznaivy opened this issue 2 years ago • 2 comments

The failure of previous code checking was probably due to the aelf node still in an old version. One more code checking will help this aelf node sync new blocks as expected.

EanCuznaivy avatar Sep 21 '22 10:09 EanCuznaivy

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

No other active qualified developers found to review these specific changes. You might consider involving more team members with these code segments.


Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
src/AElf.Kernel.CodeCheck/ContractCodeHashMap.cs50.00 %6 out of 12 times
...src/AElf.Kernel.CodeCheck/Application/ICheckedCodeHashPro50.00 %6 out of 12 times
src/AElf.Kernel.CodeCheck/CodeCheckAElfModule.cs50.00 %6 out of 12 times
protobuf/acs0.proto50.00 %6 out of 12 times
contract/AElf.Contracts.Genesis/BasicContractZeroState.cs41.67 %5 out of 12 times
...src/AElf.Kernel.CodeCheck/CodeCheckRequiredLogEventProces41.67 %5 out of 12 times
...src/AElf.Kernel.CodeCheck/NewIrreversibleBlockFoundEventH41.67 %5 out of 12 times
src/AElf.Kernel.CodeCheck/AElf.Kernel.CodeCheck.csproj41.67 %5 out of 12 times

Committed file ranks

  • 66.78%[...src/AElf.Kernel.CodeCheck/Application/CodeCheckValidation]
  • vizipi[bot] avatar Sep 21 '22 10:09 vizipi[bot]

    Codecov Report

    Merging #3328 (032d823) into dev (248dd94) will decrease coverage by 0.00%. The diff coverage is 0.00%.

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3328      +/-   ##
    ==========================================
    - Coverage   89.24%   89.23%   -0.01%     
    ==========================================
      Files         629      629              
      Lines       25154    25156       +2     
      Branches     2210     2210              
    ==========================================
      Hits        22448    22448              
    - Misses       2442     2444       +2     
      Partials      264      264              
    
    Impacted Files Coverage Δ
    ...deCheck/Application/CodeCheckValidationProvider.cs 0.00% <0.00%> (ø)

    codecov[bot] avatar Sep 21 '22 11:09 codecov[bot]