AElf icon indicating copy to clipboard operation
AElf copied to clipboard

[WIP] Add Weight in VoteRecord

Open apweili opened this issue 4 years ago • 2 comments

The voteRecord's weight is calculated instantly in GetElectorVoteWithRecords,it may change after modifying the formula.

apweili avatar Sep 18 '20 02:09 apweili

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % EanCuznaivy 196 6
100.00 % xiangxingxing 33 6
100.00 % jason-hoopox 12 6
100.00 % Peng Rong 9 6
83.33 % swk 13 5
83.33 % 轩辕焮痕 1 5

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
protobuf/election_contract.proto83.33 %10 out of 12 times
test/AElf.Contracts.Election.Tests/BVT/ElectionTests.cs83.33 %10 out of 12 times
contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs83.33 %10 out of 12 times
contract/AElf.Contracts.Treasury/TreasuryContract.cs83.33 %10 out of 12 times
protobuf/token_contract.proto83.33 %10 out of 12 times
...contract/AElf.Contracts.Election/ElectionContract_Maintai83.33 %10 out of 12 times
...contract/AElf.Contracts.Consensus.AEDPoS/AEDPoSContract_V83.33 %10 out of 12 times
contract/AElf.Contracts.Consensus.AEDPoS/AEDPoSContract.cs83.33 %10 out of 12 times
test/AElf.Contracts.TestBase/ContractTester.cs83.33 %10 out of 12 times
...test/AElf.WebApp.Application.Chain.Tests/BlockChainAppSer83.33 %10 out of 12 times

Committed file ranks

  • 97.62%[contract/AElf.Contracts.Vote/VoteContract.cs]
  • 99.55%[contract/AElf.Contracts.Profit/ProfitContract.cs]
  • 98.69%[contract/AElf.Contracts.Election/ViewMethods.cs]
  • 96.72%[protobuf/vote_contract.proto]
  • 99.33%[...contract/AElf.Contracts.Election/ElectionContract_Elector]
  • 96.18%[test/AElf.Contracts.Election.Tests/BVT/ElectionViewTests.cs]
  • vizipi[bot] avatar Sep 18 '20 03:09 vizipi[bot]

    Codecov Report

    Merging #3059 into dev will increase coverage by 7.33%. The diff coverage is 100.00%.

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3059      +/-   ##
    ==========================================
    + Coverage   85.51%   92.84%   +7.33%     
    ==========================================
      Files         605      605              
      Lines       22513    22518       +5     
      Branches     1850     1851       +1     
    ==========================================
    + Hits        19251    20906    +1655     
    + Misses       3015     1440    -1575     
    + Partials      247      172      -75     
    
    Impacted Files Coverage Δ
    contract/AElf.Contracts.Profit/ProfitContract.cs 95.62% <ø> (ø)
    ...Elf.Contracts.Election/ElectionContract_Elector.cs 98.97% <100.00%> (+0.21%) :arrow_up:
    contract/AElf.Contracts.Election/ViewMethods.cs 89.75% <100.00%> (+3.63%) :arrow_up:
    contract/AElf.Contracts.Vote/VoteContract.cs 100.00% <100.00%> (+22.64%) :arrow_up:
    src/AElf.Core/ITaskQueue.cs 98.73% <0.00%> (ø)
    ...ct/AElf.Contracts.MultiToken/TokenContract_Fees.cs 94.25% <0.00%> (ø)
    .../AElf.Contracts.Consensus.AEDPoS/AEDPoSContract.cs 88.46% <0.00%> (ø)
    ...ontracts.Election/ElectionContract_Maintainence.cs 88.33% <0.00%> (ø)
    ...nsensus.AEDPoS/Application/SecretSharingService.cs 78.26% <0.00%> (ø)
    ...us.Core/Application/ConsensusValidationProvider.cs 77.77% <0.00%> (ø)
    ... and 85 more

    codecov[bot] avatar Sep 18 '20 03:09 codecov[bot]