AElf
AElf copied to clipboard
[WIP] crypto uses object pool
Pull request analysis by VIZIPI
Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below ) Feedback always welcome
Reviewers with knowledge related to these changes
| Match % | Person | Commit Count | Common Files |
|---|---|---|---|
| 100.00 % | xiangxingxing | 24 | 2 |
| 100.00 % | Peng Rong | 18 | 2 |
| 100.00 % | EanCuznaivy | 14 | 2 |
| 100.00 % | ZhangXin | 10 | 2 |
| 100.00 % | weili | 6 | 2 |
| 50.00 % | jason-hoopox | 17 | 1 |
Potential missing files from this Pull request
files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
| File | Percentile | rate |
| protobuf/kernel.proto | 80.00 % | 8 out of 10 times |
| src/AElf.Kernel.Consensus.AEDPoS/AEDPoSAElfModule.cs | 80.00 % | 8 out of 10 times |
| ...test/AElf.WebApp.Application.Chain.Tests/BlockChainAppSer | 70.00 % | 7 out of 10 times |
| src/AElf.Kernel.TransactionPool/Infrastructure/TxHub.cs | 70.00 % | 7 out of 10 times |
| ...src/AElf.Blockchains.BasicBaseChain/BasicBaseChainAElfMod | 70.00 % | 7 out of 10 times |
| ...src/AElf.WebApp.Application.Chain/TransactionResultAppSer | 70.00 % | 7 out of 10 times |
| contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs | 70.00 % | 7 out of 10 times |
| protobuf/token_contract.proto | 70.00 % | 7 out of 10 times |
| ...src/AElf.Kernel.SmartContractExecution/Application/Blockc | 70.00 % | 7 out of 10 times |
| ...src/AElf.Kernel.TransactionPool/TransactionPoolAElfModule | 70.00 % | 7 out of 10 times |
Committed file ranks
(click to expand)
90.57%[src/AElf.Cryptography/CryptoHelper.cs] 96.77%[src/AElf.Kernel.Core/CoreKernelAElfModule.cs]
Codecov Report
Merging #2695 into dev will decrease coverage by
4.63%. The diff coverage is81.37%.
@@ Coverage Diff @@
## dev #2695 +/- ##
==========================================
- Coverage 76.11% 71.48% -4.64%
==========================================
Files 665 692 +27
Lines 25736 32762 +7026
Branches 2127 3917 +1790
==========================================
+ Hits 19590 23419 +3829
- Misses 5983 8585 +2602
- Partials 163 758 +595
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/AElf.Cryptography/CryptoHelper.cs | 83.70% <81.25%> (+2.05%) |
:arrow_up: |
| src/AElf.Kernel.Core/CoreKernelAElfModule.cs | 100.00% <100.00%> (ø) |
|
| ...nel/Miner/Application/BlockTemplateMinerService.cs | 25.00% <0.00%> (-75.00%) |
:arrow_down: |
| ...onPool/Application/TransactionValidationService.cs | 25.00% <0.00%> (-75.00%) |
:arrow_down: |
| src/AElf.OS/Worker/PeerDiscoveryWorker.cs | 31.57% <0.00%> (-68.43%) |
:arrow_down: |
| src/AElf.CrossChain.Core/CrossChainService.cs | 28.57% <0.00%> (-62.74%) |
:arrow_down: |
| ...ication/IrreversibleBlockFoundLogEventProcessor.cs | 32.07% <0.00%> (-62.37%) |
:arrow_down: |
| src/AElf.OS/Worker/PeerReconnectionWorker.cs | 12.30% <0.00%> (-60.42%) |
:arrow_down: |
| ....Core/Blockchain/Application/IBlockchainService.cs | 39.87% <0.00%> (-60.13%) |
:arrow_down: |
| ...ore/Blockchain/Domain/ITransactionResultManager.cs | 40.00% <0.00%> (-60.00%) |
:arrow_down: |
| ... and 226 more |