Super-2023-Swadge-FW icon indicating copy to clipboard operation
Super-2023-Swadge-FW copied to clipboard

Published 20 hours ago • verified publisher icon AEFeinstein

Onboard Manual

Open dylwhich opened this issue 2 years ago • 5 comments

dylwhich avatar Dec 16 '22 04:12 dylwhich

Have you coordinated with thaeli about this?

AEFeinstein avatar Dec 16 '22 14:12 AEFeinstein

Have you coordinated with thaeli about this?

I talked to thaeli earlier today, and I got her raw Google form submission csv, so I can make a rough pass at slapping that into markdown formatting tomorrow

Brycey92 avatar Dec 23 '22 03:12 Brycey92

Not ready for merge as-is. Newlines are broken, as are horizontal rules. In my testing, the issue persisted before my and Max's changes at https://github.com/AEFeinstein/Super-2023-Swadge-FW/pull/379/commits/072dc2b5dde0efdcc381980c7645d365ffece060, and at https://github.com/AEFeinstein/Super-2023-Swadge-FW/pull/379/commits/db710d8196b12a52a6d9c489a39d458e98b2fca7, before merging main. Also tested on onboard-manual-take-2-before-bryce-messed-with-it and issues persisted. Clean builds every time.

Oddly, I went back to each commit on December 6, when dylwhich was showing me those features working, but they were broken on those commits too. It's possible this is an issue on my dev environment, or that dylwhich has uncommitted changes. Can anyone confirm or deny these issues?

Working display for reference image

Brycey92 avatar Dec 23 '22 06:12 Brycey92

I don't have enough time to review and test something this large before magfest, and the actual manual entries aren't written yet, so this is not gonna make the 1.1 cut. I'll leave the PR though. It's definitely something worth fiddling with for next year, though perhaps in a simpler manner.

AEFeinstein avatar Dec 23 '22 17:12 AEFeinstein

@dylwhich discovered #386, and I made a PR to fix it in #389. This makes newlines and horizontal rules work when building on Windows.

Brycey92 avatar Dec 24 '22 05:12 Brycey92