AcDisplay icon indicating copy to clipboard operation
AcDisplay copied to clipboard

Launch any App by Corner Gesture

Open ghost opened this issue 9 years ago • 12 comments

Hello !

Loved the 3.6 version.

I have a small feature request. Why not enable the launching of ANY user selected apps through corner gestures? Why only Dialer and Camera? If you can include this, it'll really be helpful.

Thanks.

ghost avatar May 05 '15 04:05 ghost

@AChep, AcDisplay is already my favorite lockscreen because I love the simplicity and minimality of it, but if you added this, it would be even more perfect!

I have forked your code and tried to find where this stuff is handled, without luck, so many classes, haha.

ghost avatar Jun 26 '15 06:06 ghost

@hipio yeah, this feature is in my to-do list. However, https://github.com/AChep/AcDisplay/blob/master/project/app/src/main/java/com/achep/acdisplay/ui/CornerHelper.java is that class you have been looking for.

AChep avatar Jun 26 '15 06:06 AChep

@AChep Thanks! I'll take a look this weekend (need to finish up some school work first) and see if I can implement it myself. I've added a $5 bounty to this suggestion as a thank you or motivation to work on this. :P

ghost avatar Jun 26 '15 06:06 ghost

@AChep, where can I find the dialog that shows the possible options? I have added my option and the number in the array.xml (I can select it so that works), changed the config, added my stuff to the CornerHelper and all I need to do now is let the user pick an app they want to launch and save it's package name. But to do that, I need to know where the dialog is created. :P

ghost avatar Jun 26 '15 08:06 ghost

@hipio currently there's no custom dialog for that :) You'll have to create a one. Example: https://github.com/AChep/AcDisplay/tree/master/project/app/src/main/java/com/achep/acdisplay/ui/preferences

AChep avatar Jun 26 '15 08:06 AChep

@AChep Well, I got everything working, except that the icon of the app is totally black (it uses the PackageManager to extract the Drawable from a custom app, which I assign to mDrawable in CircleView in the updateIcon() function). Not sure where the Drawable is made black though. Must be an inversion somewhere as you use white icons.

EDIT: Nevermind, fixed it. I just realized that I'm currently trying to save 4 app package names in 1 value. That ain't going to work. Need to fix that and then I should be ready to send you a pull request. Probably ain't the prettiest thing you have seen (has been a while since I used Android).

ghost avatar Jun 27 '15 20:06 ghost

@AChep Pull request created. https://github.com/AChep/AcDisplay/pull/93#partial-pull-merging

ghost avatar Jun 28 '15 12:06 ghost

Is there any update on this as it is a neat feature?

roryclaasen avatar Sep 04 '15 18:09 roryclaasen

@AChep Any ETA on when my push (#93) is getting merged?

ghost avatar Oct 20 '15 15:10 ghost

I'm going to assume that #93 this will not be merged.

ghost avatar Sep 22 '16 21:09 ghost

Just curious as to the status of this issue/pr? Seems dormant atm, but this would be a great feature.

michaeltaranto avatar Dec 13 '16 12:12 michaeltaranto

I'm taking care of this PR now.

CarlosACepeda avatar Jul 02 '19 22:07 CarlosACepeda