Andrew Kelley

Properly setup Active Storage

2

Line #11 in config/environments/production reads: config.active_storage.service = :local With the Heroku setup, shouldn't there be an ENV variable here so users can set it to a third-party service (ex: AWS)?

Compression via Rack::Deflater

1

Is there a reason that "Rack::Deflater middleware" isn't being used? I didn't see "config.middleware.use Rack::Deflater" in config/application.rb.

Incorrect formula for FV calculation

1

The FV formula asks for the number of "periods". However, the wording should be changed to "years". For example, a year might have 12 periods which means that the cumulative...

I deleted the exclude assets line, but the update page still doesn't load the site asset files

Chapter 6 - Rspec-rails should be "group :development, :test"

3

In the end of Chapter 6, the 'rspec-rails' gem is in "group :test". I'd recommend adding it to "group :development, :test" so that it works for rake tasks and generators....

Chapter 7 - Show code changes to users_controller_spec.rb file when serializing

3

It would be nice to see at a quick glance what changes to the users_controller_spec.rb were made at the start of Chapter Seven. However, you do get a better understanding...

Don't set the user_id manually

3

In Chapter 6, you set the user_id manually. ``` post :create, { user_id: user.id, product: @product_attributes } ``` This should automatically be set using the current_user attribute in the controller.

Use SSL for sabisu-rails

1

I'd recommend using: ``` 'sabisu_rails', git: "https://github.com/icaliaLabs/sabisu-rails" ```

When using ``` window.status = "JS_DONE";```, I find that the code sometime never runs and Sidekiq keeps the job running for hours. When using wicked_pdf, how can we set a...