phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

Button text should change dynamically

Open bitcoinuser opened this issue 4 years ago • 5 comments

Hi,

On send window the text (Paste payment request) should show if what is copied is a lightning invoice. But if what is copied is a bitcoin address, the text should be changed to (Paste bitcoin address).

photo_2020-04-29_15-24-55

bitcoinuser avatar Apr 29 '20 18:04 bitcoinuser

And if nothing is copied on clipboard, maybe the button should be hidden. Do not appear.

bitcoinuser avatar Apr 29 '20 19:04 bitcoinuser

Hi @dpad85,

Maybe this issue can contain the tag "good first issue", I think it is good to start to read the code with something to resolve. In addition, if the PRs are welcome and it issue is still unresolved, I want ask if I can take the lock about this issue. :smile:

vincenzopalazzo avatar Jul 12 '20 05:07 vincenzopalazzo

Hi Vincenzo, you can take this issue if you want. I'm not a big fan of having an app watching my clipboard, I find it quite invasive. It does provide good UX for new users though!

dpad85 avatar Jul 20 '20 13:07 dpad85

Hi @dpad85,

Thank you. I also noted that the text inside the paste button was already changed, so the next step to do is hide the button is inside the clipboard if there isn't something interesting, right?

vincenzopalazzo avatar Jul 20 '20 13:07 vincenzopalazzo

Or maybe just disable or blur the button, so first time users notice the feature. Isn't that what already happens? I don't have my phone with me right now, but seem to remember that.

And if nothing is copied on clipboard, maybe the button should be hidden. Do not appear.

Hi @dpad85,

Thank you. I also noted that the text inside the paste button was already changed, so the next step to do is hide the button is inside the clipboard if there isn't something interesting, right?

mautematico avatar Jul 21 '20 16:07 mautematico