phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

Typing "email" address support

Open Sjors opened this issue 1 year ago • 5 comments

Typing an email / lightning / bip353 address right in the app is often more convenient than having to scan or paste it. I find myself typing it in another app and then pasting it.

Sjors avatar Jul 11 '24 18:07 Sjors

(and it should probably track recipients so you can send them money again, but that's potentially much more involved)

Sjors avatar Jul 11 '24 18:07 Sjors

The "send" view is going to be reworked. It was designed around a bolt11 payment flow where most of the time you had to scan a QR code to do anything.

But now, with static payment instructions becoming more prevalent, that screen should be designed around a contacts/recent payments UI + a free form text input. There will still be a button somewhere to open the scanner but it should not be the default.

@robbiehanson that will be a good opportunity to rework the ScanController class, maybe remove the MVI pattern as well.

dpad85 avatar Jul 12 '24 08:07 dpad85

I've been playing with the "Contacts" feature and it would be nice to be able to add a lno offer to my contact list using someone's bip353 address also.

notmandatory avatar Aug 21 '24 18:08 notmandatory

@notmandatory I think you can now save it when you send the first time.

Sjors avatar Aug 21 '24 18:08 Sjors

@Sjors thanks for the tip! I tired it (iOS/v2.3.2) and when I manually input the bip-353 lno address I was given a little button to add that address to a new contact in my contacts. I also confirmed that if I manually enter the address for an existing contact that the payment screen detects that and shows me the contacts name on the confirm payments screen.

notmandatory avatar Aug 21 '24 20:08 notmandatory

Fixed via #629 & #643

robbiehanson avatar Dec 03 '24 02:12 robbiehanson