lightning-kmp icon indicating copy to clipboard operation
lightning-kmp copied to clipboard

Retrieve onchain feerate when we connect to an electrum server

Open sstone opened this issue 1 year ago • 3 comments

When we connect to an electrum server we perform a "handshake" that includes exchanging protocol version messages and retrieving the server's current tip, and now we also retrieve onchain fees.

sstone avatar Jun 27 '23 07:06 sstone

Moving fee retrieval into the electrum handshake means that if the server returns an error it will be caught by our coroutine exception handler and will not crash the application (as in the case now), I included a test for that.

sstone avatar Jun 29 '23 17:06 sstone

Isn't this obsolete after #649 where we let our peer advertise the feerates they accept through the recommended_feerates message?

t-bast avatar Sep 18 '24 13:09 t-bast

I don't think so since we still ask the electrum server we're connected to for fee estimates and it may return an error ? The point here was do we add this to the handshake we perform when we connect to the server or do we try a different fix.

sstone avatar Sep 18 '24 14:09 sstone