Add support for taproot outputs to our "input info" class
This is a preparation PR for simple taproot channels, which extends InputInfo to support spending taproot outputs (to spend v0 outputs we need a redeem script, but to spend v1 taproot output we need a script tree and an internal public key).
Changes are generic (i.e. not tied to specific details of the simple taproot channels extension proposal).
This PR is now based on https://github.com/ACINQ/eclair/pull/2747
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 86.30137% with 50 lines in your changes missing coverage. Please review.
Project coverage is 86.02%. Comparing base (
5410146) to head (a842915). Report is 19 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #2895 +/- ##
==========================================
- Coverage 86.19% 86.02% -0.17%
==========================================
Files 224 227 +3
Lines 20074 20610 +536
Branches 813 816 +3
==========================================
+ Hits 17302 17729 +427
- Misses 2772 2881 +109
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...core/src/main/scala/fr/acinq/eclair/Features.scala | 100.00% <100.00%> (ø) |
|
| ...in/scala/fr/acinq/eclair/channel/ChannelData.scala | 100.00% <100.00%> (ø) |
|
| ...in/scala/fr/acinq/eclair/channel/Commitments.scala | 96.66% <100.00%> (-0.17%) |
:arrow_down: |
| ...a/fr/acinq/eclair/channel/fsm/CommonHandlers.scala | 89.36% <100.00%> (+4.06%) |
:arrow_up: |
| ...inq/eclair/channel/fund/InteractiveTxBuilder.scala | 93.03% <100.00%> (ø) |
|
| ...air/crypto/keymanager/LocalChannelKeyManager.scala | 100.00% <100.00%> (ø) |
|
| ...n/scala/fr/acinq/eclair/io/PeerReadyNotifier.scala | 71.75% <100.00%> (+0.21%) |
:arrow_up: |
| ...n/scala/fr/acinq/eclair/json/JsonSerializers.scala | 96.42% <ø> (ø) |
|
| ...ire/internal/channel/version0/ChannelCodecs0.scala | 95.85% <100.00%> (+0.02%) |
:arrow_up: |
| ...wire/internal/channel/version0/ChannelTypes0.scala | 100.00% <100.00%> (ø) |
|
| ... and 15 more |
I think this is now a safe refactoring that we should put on master to simplify dependent PRs. Since #2747 is still blocked waiting for lnd to finish their implementation, can you rebase this PR directly on master? This way we can integrate it this week.
rebased on master (27ba60f2416c47c6315139f0cb21894534cad890)