eclair icon indicating copy to clipboard operation
eclair copied to clipboard

Unkown ChannelIDs passed to FindRoute throws exception

Open DerEwige opened this issue 3 years ago • 0 comments

Invalide ShortChannelIDs (format, etc.) should totally throw exeptions on this option, but not Unknown Channels imho.

Tested version: Eclair v0.7.0

Description: The API functions [FindRoute, FindRouteToNode, FindRouteBetweenNodes] have an option ignoreShortChannelIds. If you pass a no longer existing ShortChannelId to this option it will give an error.

2022-07-16 09:27:48,760 ERROR f.a.eclair.Boot - API call failed with cause=unknown channel: 745034x723x1

In my opinion this should not throw an error. You try to find a route ignoring a channel, if eclair does not know this channel, this is fine as it is ignored implicitly and does not need to be ignored explicitly. I would much rather prefer a warning instead for this 3 functions on unknown ShortChannelIds passed.

DerEwige avatar Jul 16 '22 07:07 DerEwige