eclair icon indicating copy to clipboard operation
eclair copied to clipboard

Update bitcoind to 22.0

Open t-bast opened this issue 3 years ago • 3 comments

There was no release 22.1 made this time, and it looks like bitcoin core is focusing on the upcoming 23.0 release, so we should support 22.0.

We also drop support for versions < 0.21.1, which lets us simplify some of our tx publishing code (that worked around a bitcoind bug).

t-bast avatar Jan 19 '22 16:01 t-bast

Codecov Report

Merging #2135 (ca98163) into master (e2b1b26) will increase coverage by 0.00%. The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #2135   +/-   ##
=======================================
  Coverage   87.42%   87.43%           
=======================================
  Files         170      170           
  Lines       13198    13192    -6     
  Branches      539      533    -6     
=======================================
- Hits        11538    11534    -4     
+ Misses       1660     1658    -2     
Impacted Files Coverage Δ
...q/eclair/channel/publish/ReplaceableTxFunder.scala 87.02% <75.00%> (+0.11%) :arrow_up:
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 95.93% <0.00%> (-1.63%) :arrow_down:
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 85.82% <0.00%> (+0.38%) :arrow_up:
...clair/channel/publish/ReplaceableTxPublisher.scala 75.37% <0.00%> (+1.49%) :arrow_up:

codecov-commenter avatar Jan 19 '22 16:01 codecov-commenter

It seems that there is a 22.1 milestone (see https://github.com/bitcoin/bitcoin/milestone/55) but I could not find a release date

sstone avatar Jan 20 '22 17:01 sstone

Good catch! Let's wait and see how that progresses. I wanted to experiment with bitcoind 22.0 for the --include_unsafe feature in fundrawtransaction. But I'm just prototyping for now, that's why I kept this PR a draft.

t-bast avatar Jan 20 '22 17:01 t-bast