eclair icon indicating copy to clipboard operation
eclair copied to clipboard

Use psbt to fund and sign transactions

Open sstone opened this issue 3 years ago • 1 comments

Based on https://github.com/ACINQ/eclair/pull/2038. We use bitcoin-kmp's Psbt classes and methods directly (there is no need for a wrapper here imho).

sstone avatar Jan 03 '22 19:01 sstone

Codecov Report

Merging #2120 (d864edb) into master (0de91f4) will decrease coverage by 0.02%. The diff coverage is 88.09%.

@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
- Coverage   84.88%   84.85%   -0.03%     
==========================================
  Files         198      198              
  Lines       15796    15841      +45     
  Branches      658      675      +17     
==========================================
+ Hits        13408    13442      +34     
- Misses       2388     2399      +11     
Impacted Files Coverage Δ
...ala/fr/acinq/eclair/blockchain/OnChainWallet.scala 100.00% <ø> (ø)
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala 86.16% <ø> (ø)
...q/eclair/channel/publish/ReplaceableTxFunder.scala 85.64% <82.14%> (-1.27%) :arrow_down:
...ir/blockchain/bitcoind/rpc/BitcoinCoreClient.scala 94.73% <100.00%> (-1.63%) :arrow_down:
...q/eclair/channel/fsm/ChannelOpenSingleFunded.scala 94.16% <100.00%> (-0.03%) :arrow_down:
...fr/acinq/eclair/channel/InteractiveTxBuilder.scala 84.55% <0.00%> (-1.05%) :arrow_down:
...clair/channel/publish/ReplaceableTxPublisher.scala 74.19% <0.00%> (+0.64%) :arrow_up:

codecov-commenter avatar Jan 03 '22 19:01 codecov-commenter

Not needed anymore, see https://github.com/ACINQ/eclair/pull/2613

sstone avatar Mar 16 '23 13:03 sstone