eclair icon indicating copy to clipboard operation
eclair copied to clipboard

Handling of pruned channels that come back to life is very inefficient

Open pm47 opened this issue 4 years ago • 0 comments

When we get a valid channel_update for a pruned channel, we add a QueryShortChannelIds containing a single shortChannelId to our batch. If a node has been shut down for a long time, this will result in a lot of queries and be very inefficient. Instead, we should just add the shortChannelId to an existing QueryShortChannelIds

https://github.com/ACINQ/eclair/blob/f7a79d10b4ddb6f91a4c66983c7a1620cc572e72/eclair-core/src/main/scala/fr/acinq/eclair/router/Validation.scala#L379-L389

pm47 avatar Nov 04 '21 14:11 pm47