eclair-mobile icon indicating copy to clipboard operation
eclair-mobile copied to clipboard

Enable bech32 receive address

Open mikeroberts76 opened this issue 5 years ago • 7 comments

Please, with bech32 addresses fees are lower.

mikeroberts76 avatar Apr 01 '19 01:04 mikeroberts76

Selection of "native" & "non-native" receive address for on-chain funding would be very nice

mikeroberts76 avatar Apr 03 '19 15:04 mikeroberts76

Yes we would like to support bech32 addresses (we chose p2sh-of-p2wpkh because there are still many wallets and services that don't understand bech32), but it's not scheduled yet and not that simple (how do we offer this option and migrate existing wallets, deal with pending closing txs, ....) so we cannot announce a release date.

sstone avatar Apr 05 '19 09:04 sstone

@dpad85 sorry for mentioning you, but is there any ETA for this?

Iffabled avatar Oct 11 '19 20:10 Iffabled

As mentioned in the previous comment, this needs a major rewrite of the wallet, I think.

maflcko avatar Oct 11 '19 21:10 maflcko

@MarcoFalke I really don't think so... ACINQ already released their brand new 2nd-gen wallet called Phoenix, which will only generate Bech32 addresses. They already got corresponding libraries too. The famous wasabi wallet featuring CoinJoin only scans/recognizes Bech32 Addresses. Even BLW (Bitcoin Lightning Wallet, also present on bitcoin.org's wallet list, with only 1 major contributor) generates Bech32 addresses. Eclair mobile is (a little bit) left behind...

cyanlink avatar Mar 07 '20 10:03 cyanlink

As mentioned by @sstone in the comment above, the issue is how to migrate existing wallets to bech32. Ideally we'd have an automated migration system that would take care of that behind the scene, but that's not easy to do.

I think a fair solution would be that, from now on, every newly created wallet would be a bech32 wallet. Users willing to migrate would have to do that manually. We would have to add some instructions in the app to describe the process, which is:

  1. Make sure all channels are closed
  2. Send all funds somewhere else
  3. Reset data/uninstall
  4. Create new wallet

Also the "Restore wallet" page would need to know what kind of seed the user is trying to restore, which means adding a selection box in the UI with some very technical content that will confuse newcomers. But it's worth it.

dpad85 avatar Mar 09 '20 13:03 dpad85

why don't we treat the old p2wpk like an "old address". The seed generates 2 private keys, one for p2wpk, one for bech32, in the background.

If the user is an old user, has fund/channel in old p2wpk, then run 2 processes, transparently dealing both, and always gives the user the bech32 receiving address as default, to promote user slowly move to bech32.

If the user is new, has no money no channel in the p2wpk private key, great! Simply run the bech32 process only from now on.

Kylejustknows avatar Nov 10 '21 05:11 Kylejustknows