ngx-text-diff icon indicating copy to clipboard operation
ngx-text-diff copied to clipboard

Published 20 hours ago • verified publisher icon ABenassi87

Updating to latest angular version

Open joanofdart opened this issue 3 years ago • 18 comments

Might as well help by updating this package dependencies along with other goodies. Some things are missing? perhaps removing tslint and whatnot but the critical aspect of what is needed, has been updated.

@ABenassi87 please take a look, thanks.

joanofdart avatar Jan 18 '22 22:01 joanofdart

Can we please get this reviewed?

wojo1086 avatar Jan 25 '22 06:01 wojo1086

@joanofdart thank you so much for this PR. I was very busy with some stuff. I will take a look this weekend and if all is good, I will release a new version next week. Thank you so much for your contribution.

ABenassi87 avatar Jan 25 '22 19:01 ABenassi87

I too would much appreciate this PR. I have tested it locally without issues.

swedishcodemonkey avatar Feb 02 '22 16:02 swedishcodemonkey

lets wait for @ABenassi87 to give it the thumbs up :)

joanofdart avatar Feb 02 '22 20:02 joanofdart

Absolutely! Just tried to be helpful 🙂

swedishcodemonkey avatar Feb 02 '22 21:02 swedishcodemonkey

@ABenassi87 just wondering what is it taking this long? :D People want/need this and I have no idea why its being delayed this much.

joanofdart avatar Feb 10 '22 21:02 joanofdart

@ABenassi87 any update on this? Would be great to use this with newer versions of Angular

miccou avatar Feb 25 '22 05:02 miccou

It's been 3-4 months still the PR is open. @ABenassi87 It will be great if you can have version and backward compatibility with angular.

vishalbiradar avatar Apr 21 '22 10:04 vishalbiradar

@ABenassi87 would you like to add a few more core maintainers so we can help to resolve this issue?

NZE avatar Jul 13 '22 01:07 NZE

@ABenassi87 or make it a paid project so you can afford to work on it

SimonCropp avatar Jul 13 '22 01:07 SimonCropp

@joanofdart Hi, I saw you forked this repo. Would you want to publish that under a different name? I can help keep that repo up-to-date as Angular version updates.

sh977218 avatar Jul 27 '22 13:07 sh977218

@joanofdart Hi, I saw you forked this repo. Would you want to publish that under a different name? I can help keep that repo up-to-date as Angular version updates.

I could probably instead create a new one and base it off @ABenassi87 's work Could be a fun project. Let's see how many thumb ups do I get 👀

joanofdart avatar Jul 27 '22 21:07 joanofdart

I support creating a new fork under an organisation, so we can have several contributors and hopefully avoid a situation where the package gets outdated in the future.

Happy to help as a contributor if that happens.

miccou avatar Jul 27 '22 23:07 miccou

Hi there, I will review this PR, and I will merge it. Please, wait until the weekend. Thank you!

ABenassi87 avatar Jul 27 '22 23:07 ABenassi87

General question, what angular versions do you need to support? only the last one or some previous version?

ABenassi87 avatar Jul 27 '22 23:07 ABenassi87

I just started from scratch in this branch: https://github.com/ABenassi87/ngx-text-diff/tree/angular-v14

ABenassi87 avatar Jul 27 '22 23:07 ABenassi87

@ABenassi87 Hi, thanks for the updates. Are you able to publish angular-v14 to npm, maybe like under "14.0.0" so it can sync with Angular version.

sh977218 avatar Aug 05 '22 16:08 sh977218

@ABenassi87 Hi, thanks for the updates. Are you able to publish angular-v14 to npm any time soon?

chiafeng888 avatar Nov 16 '23 05:11 chiafeng888