Andrew Arnott
Andrew Arnott
I'm actually curious whether even the non-generic interfaces can be made abstract classes except for the root `ITypeShape` and `ITypeShape` interfaces. I'm going to explore that. The test failures are...
I mis-diagnosed the test failure. The NRE is thrown before and after, but my changes had changed the code path from one that didn't throw to the one that did.
> My only concern is that we won't ever be able to convert the non-generic types into abstracts No need to fret. I made those abstract classes too. :)
I think this change is about ready. If you agree with the design decisions I made (e.g. how I workaround C#'s inability to both override and declare a new member...
Fair enough. But by the same token, why is `[IgnoreMember]` on a private member if private members are implicitly ignored?
I think you found at least one bug in the analyzers. I don't know when we'll get to it, but let's keep the bug active.
This is the JSON schema that Visual Studio 17.14 uses: https://gist.github.com/AArnott/ea481eeb07fb78b4b6bf4b7436d88009
> While JSON is the current convention, and one I think should absolutely continue to be supported, some users might prefer YAML for its flexibility and readability. YAML offers: I'm...
@eiriktsarpalis Please set the 1.0 milestone to this issue. IIRC you mentioned this should only be done to the generic shape interfaces rather than the non-generic ones. I suspect that's...
I've done some of the work for this, but to avoid merge conflicts with #165 I'm going to hold off doing more work until that PR has merged.